On Tue, 2010-09-07 at 16:56 -0400, Konrad Rzeszutek Wilk wrote: > > Hi Konard, > > > > I just pushed most of your recommend cleanups for target_core_base.h to > > lio-core-2.6.git/lio-4.0. The cleanup series has been posted on > > lio-devel list to prevent extra noise on linux-scsi, et al, but for > > reference the shortlog and diffstat are attached below.. I did not dive > > into intermixed struct + #defines, but I am still pretty indifferent on > > this particular item. > > > > So the reasons why I thought it would be a good idea to combine the #defines > and the values and also dropping the prefix of structs for all of the 'flag' > members is that: > > 1) once you have them intermixed, searching for a particular flag either using > cscope/ctags becomes easier. You have the definition of the 'flag' and the > different values it can have in one localized spot. It also removes your > worry about the 'grep' - you usually search for the values that a specific > flag has and if you use that tool you can find it right there along with the > structure it was defined in. > > 2). From a perspective of a vendor maintainer who has to find a fix, getting > familiarized with the code within a short window time frame and having the > acceptable states and its definitions in one place (and even pointers to the > specs if there are some) makes it sooo much easier to grok the code. > Having even nice ascii art of how/what works together is even better. Ok, I think these are both reasonable points for combining the #defines near the structure members where they are actually used. I will go ahead and make this change, but I would still like to keep the exiting prefixes for structure members for now. Thanks for your comments Konrad! --nab -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
