On Tue, Sep 7, 2010 at 5:45 AM, Chetan Loke <chetanloke@xxxxxxxxx> wrote: > [ ... ] > > I would also appreciate an overview or a block diagram of how things > work in LIO. I hope that's not too much to ask for? That way we can > compare/contrast how things work from 10,000 feet level. > I for one don't want to look at a single patch and comment - > i) Oh, change this variable here because it doesn't follow linux coding style. > ii) You dropped a lock in queue-cmd? Good. qla's driver has been doing > it for sometime, no? So you could have just looked at that LLDD. > > Sorry, not trying to criticize anything but would like to offer my 2 cents too. I agree with you. Not only the code of the two projects should be reviewed but their respective designs should be reviewed too. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
