Re: [PATCH] scsi: fix SCSI_SAS_ATTRS' reference to BLK_DEV_BSG

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 02 Sep 2010 14:13:45 +0100 Jan Beulich wrote:

> Since SCSI_SAS_ATTRS gets selected in a few places, making it merely
> depend on the (user selectable) BLK_DEV_BSG isn't correct (as the
> result may be that the latter doesn't get enabled, which recent
> kconfig validly warns about). Convert the "depends on" to a "select".
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
> Cc: Fujita Tomonori <fujita.tomonori@xxxxxxxxxxxxx>
> 
> ---
>  drivers/scsi/Kconfig |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --- linux-2.6.36-rc3/drivers/scsi/Kconfig
> +++ 2.6.36-rc3-scsi-sas-attrs/drivers/scsi/Kconfig
> @@ -316,7 +316,8 @@ config SCSI_ISCSI_ATTRS
>  
>  config SCSI_SAS_ATTRS
>  	tristate "SAS Transport Attributes"
> -	depends on SCSI && BLK_DEV_BSG
> +	depends on SCSI
> +	select BLK_DEV_BSG
>  	help
>  	  If you wish to export transport-specific information about
>  	  each attached SAS device to sysfs, say Y.
> 
> 
> 
> --

Ack if it will help.
http://marc.info/?l=linux-scsi&m=128214896025671&w=2

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux