On Thu, 2010-08-26 at 08:00 +0200, Bart Van Assche wrote: > On Thu, Aug 26, 2010 at 1:58 AM, Jean Sacren <sakiwit@xxxxxxxxx> wrote: > > > > warning: zero-length gnu_printf format string > > > > Fix the above warning by inserting a space into the literal string. > [ ... ] > > - scmd_printk(KERN_INFO, cmd, ""); > > + scmd_printk(KERN_INFO, cmd, " "); > > Hello Jean, > > Have you considered to replace the empty string by "%s", "" or to > submit a patch that disables the compiler warning on empty format > strings ? Actually, I wouldn't do that. The warning is controversial and recently introduced. Proposing a patch to disable it would step into a fairly huge controversy. The patch as is, looks fine ... it's basically what I asked of the people who did the conversion, but they contaminated their patch with a lot of unnecessary cruft, so I'll take this one. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
