>>>>> "Christoph" == Christoph Hellwig <hch@xxxxxx> writes: Christoph> On Thu, Aug 19, 2010 at 11:48:57AM -0400, Martin K. Petersen wrote: >> ATA IDENTIFY DEVICE word 105 contains the number of 512-byte blocks >> of TRIM payload information the device can accept in one command. >> Use this value to enable payloads > 512 bytes. Christoph> Currently ata_scsi_write_same_xlat passes uses a constant 512 Christoph> for the payload all over the place, so the larger payloads Christoph> won't actually work yet. Christoph> I don't think advertising a larger size than we actually Christoph> support is a good idea. I was on crack when I included this in the series last week. It came from my discard coalescing tree where things are quite different. In any case we're also limited by the range of WRITE SAME as long as we're relying on SAT. So under all circumstances we're dead in the water with a payload > 1KB. Let's just drop this one for now. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
