>>>>> "James" == James Bottomley <James.Bottomley@xxxxxxx> writes: James> Should this be unconditional? Shouldn't it be conditioned on the James> current supported trim indicator (which is word 169 being James> non-zero unless they've changed it yet again)? I thought about it. But the VPD page isn't gated on thin provisioning being enabled. With the SCSI hat on we won't enable discard unless TPE=1 in READ CAPACITY(16). Regardless of whether the device reports TPU=1 or TPWS=1 in the TP VPD. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html