On Tue, 2010-08-17 at 11:36 -0700, Randy Dunlap wrote: > From: Randy Dunlap <randy.dunlap@xxxxxxxxxx> > > Fix kconfig dependency warnings in scsi/Kconfig: > > warning: (SCSI_SAS_LIBSAS && SCSI || SCSI_MPT2SAS && SCSI_LOWLEVEL && PCI && SCSI || FUSION_SAS && FUSION && PCI && SCSI) selects SCSI_SAS_ATTRS which has unmet direct dependencies (SCSI && BLK_DEV_BSG) > > Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx> > Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx> > --- > drivers/scsi/Kconfig | 3 ++- > drivers/scsi/libsas/Kconfig | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > > --- linux-next-20100810.orig/drivers/scsi/libsas/Kconfig > +++ linux-next-20100810/drivers/scsi/libsas/Kconfig > @@ -26,6 +26,7 @@ config SCSI_SAS_LIBSAS > tristate "SAS Domain Transport Attributes" > depends on SCSI > select SCSI_SAS_ATTRS > + select BLK_DEV_BSG This isn't right if you do the below. Selects cascade. > help > This provides transport specific helpers for SAS drivers which > use the domain device construct (like the aic94xxx). > --- linux-next-20100810.orig/drivers/scsi/Kconfig > +++ linux-next-20100810/drivers/scsi/Kconfig > @@ -316,7 +316,8 @@ config SCSI_ISCSI_ATTRS > > config SCSI_SAS_ATTRS > tristate "SAS Transport Attributes" > - depends on SCSI && BLK_DEV_BSG > + depends on SCSI > + select BLK_DEV_BSG So this is the only part that's necessary, isn't it? Could you resubmit with just this? Thanks, James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
