Hello Mike, Thanks for reviewing. Since both scsi_device->lun and the local scsi_lun array variable are defined as u32 so we're using a direct u32 manipulation. It's also consistent to the old code. We chose to use memcpy for the default case as both tmfabort_wqe->lun and tmfabort_hdr->lun are defined to be u8. This u8 copying is also consistent to the other code paths in the existing bnx2i like nopout_wqe, etc. Thanks, Eddie -----Original Message----- From: Mike Christie [mailto:michaelc@xxxxxxxxxxx] Sent: Wednesday, August 11, 2010 12:07 PM To: Eddie Wai Cc: James Bottomley; open-iscsi; linux-scsi; Michael Chan; Anil Veerabhadrappa; Benjamin Li Subject: Re: [PATCH 2/5] BNX2I: Added support for other TMFs besides ABORT_TASK On 08/10/2010 02:09 PM, Eddie Wai wrote: > + /* Retrieve LUN directly from the ref_sc */ > + int_to_scsilun(ref_sc->device->lun, > + (struct scsi_lun *) scsi_lun); > + tmfabort_wqe->lun[0] = be32_to_cpu(scsi_lun[0]); > + tmfabort_wqe->lun[1] = be32_to_cpu(scsi_lun[1]); > + > + default: > + memcpy(tmfabort_wqe->lun, tmfabort_hdr->lun, 8); Why do you copy the lun differently? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
