On Wed, 28 Jul 2010, James Bottomley wrote: > Your commit: > > [SCSI] implement runtime Power Management > > This patch (as1398b) adds runtime PM support to the SCSI layer. Only > the machanism is provided; use of it is up to the various high-level > drivers, and the patch doesn't change any of them. Except for sg -- > the patch expicitly prevents a device from being runtime-suspended > while its sg device file is open. ... > has been added to the upstream SCSI tree > You can find it here: > > http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=e6eb7b8684d579a920fb2a4c5cfeaae715e0167d > > This patch is scheduled to be pushed when the merge window opens for 2.6.36 James: You haven't applied the 7-part patch series submitted here http://marc.info/?l=linux-scsi&m=127551093014580&w=2 and in the following emails. For the most part it doesn't matter; those patches are pretty trivial clean-ups. However it does matter in one regard: The 6/7 patch in that series interacts with this commit here. The logic for setting the task state in scsi_error_handler() was simplified, and without that change this implement-runtime-power-management patch leaves the state set wrong. This is a potential bug. Of course, my preference is for those seven patches to be accepted. But if you prefer, you could simply add a line setting the state to TASK_INTERRUPTIBLE before the "continue" statement added here. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
