On Tue, 27 Jul 2010, James Bottomley wrote:
> > > @@ -147,7 +148,18 @@ static inline void scsi_netlink_exit(voi
> > > /* scsi_pm.c */
> > > #ifdef CONFIG_PM_OPS
> > > extern const struct dev_pm_ops scsi_bus_pm_ops;
> > > +#ifdef CONFIG_PM_RUNTIME
> > > +extern void scsi_autopm_get_target(struct scsi_target *);
> > > +extern void scsi_autopm_put_target(struct scsi_target *);
> > > +extern int scsi_autopm_get_host(struct Scsi_Host *);
> > > +extern void scsi_autopm_put_host(struct Scsi_Host *);
> > > #else
> > > +static inline void scsi_autopm_get_target(struct scsi_target *) {}
> > > +static inline void scsi_autopm_put_target(struct scsi_target *) {}
> > > +static inline int scsi_autopm_get_host(struct Scsi_Host *) { return 0; }
> > > +static inline void scsi_autopm_put_host(struct Scsi_Host *) {}
> >
> > You didn't compile this, did you? The compiler gets distinctly annoyed
> > to see an inline function with no actual variable for the argument ...
Arggh! I hate changes that are affected by multiple configuration
options.
In fact I did test an earlier version of the patch, but it's entirely
possible that I missed one of the four combinations.
> > I fixed up this and the one in scsi_device.h
>
> Since there were actually 3 relevant config variations, this turned out
> to be the final fix.
Yep, you're absolutely right. Many thanks for fixing this up.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
