On Thu, 2010-07-22 at 17:32 -0500, Mike Christie wrote: > On 07/21/2010 05:59 PM, Jayamohan Kallickal wrote: > > This patch add NET because be2iscsi is using sysfs_format_mac function > > Found and patch originally submitted by Randy Dunlap > > > > Signed-off-by: Randy Dunlap<randy.dunlap@xxxxxxxxxx> > > Signed-off-by: Jayamohan Kallickal<jayamohank@xxxxxxxxxxxxxxxxx> > > --- > > drivers/scsi/be2iscsi/Kconfig | 2 +- > > drivers/scsi/be2iscsi/be_main.h | 1 + > > 2 files changed, 2 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/scsi/be2iscsi/Kconfig b/drivers/scsi/be2iscsi/Kconfig > > index 2952fcd..9d57142 100644 > > --- a/drivers/scsi/be2iscsi/Kconfig > > +++ b/drivers/scsi/be2iscsi/Kconfig > > @@ -1,7 +1,7 @@ > > config BE2ISCSI > > tristate "ServerEngines' 10Gbps iSCSI - BladeEngine 2" > > depends on PCI&& SCSI > > - select SCSI_ISCSI_ATTRS > > + select SCSI_ISCSI_ATTRS&& NET > > > > Bah. Ok the code in the patches looks ok, but with this patch I get: > > scripts/kconfig/mconf arch/x86/Kconfig > drivers/scsi/be2iscsi/Kconfig:4: invalid option > make[1]: *** [menuconfig] Error 1 > make: *** [menuconfig] Error 2 > > when I try to do > > make menuconfig > or > make oldconfig That's because the patch is wrong. The && NET shouldn't be on the select, it should be on the depends. So, next time, I want to see a From: A.N Author <ana@xxxxxxxx> at the front of the patch, so I pick up the correct authorship, and the rest of the change log they sent in, plus comments about any fixes or changes you made, then a signoff set. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
