improper use of the notifier API in scsi_dh_notifier()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

There seem to be a couple of bogus notifier API uses in the kernel, 
specifically, wrong return codes from the notifier routine. One of them is 
in scsi_dh_notifier(), which can return a negative error code, which is 
not what you're supposed to return from a notifier routine. Apart from 
being just a wrong use of the API, this also will trigger the

	if ((ret & NOTIFY_STOP_MASK) == NOTIFY_STOP_MASK)

test in notifier_call_chain() and thus prevent further notifiers from 
being called. Am I missing something?

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux