Hi, This one may be dropped as after almost a year of trying to get it merged [1] it seems that an added complexity of the patch is not worth the potential gains (although I can't tell for sure since feedback has been always 'minimal'). [1] http://lkml.indiana.edu/hypermail/linux/kernel/0907.3/00416.html Thanks. On Wednesday 21 July 2010 12:28:53 am akpm@xxxxxxxxxxxxxxxxxxxx wrote: > From: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> > > Dan's list included: > > drivers/scsi/scsi_lib.c +1365 scsi_kill_request(9) warning: variable derefenced in initializer 'cmd' > drivers/scsi/scsi_lib.c +1365 scsi_kill_request(9) warning: variable derefenced before check 'cmd' > > We dereference cmd (and possible OOPS if cmd == NULL) before starting the > request so just remove the superfluous debugging code altogether. > > [ bart: the potential NULL pointer dereference was finally fixed in > (much later than mine) commit 03b1470 but my patch is still valid ] > > Reported-by: Dan Carpenter <error27@xxxxxxxxx> > Cc: Jonathan Corbet <corbet@xxxxxxx> > Cc: Eugene Teo <eteo@xxxxxxxxxx> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> > Cc: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > --- > > drivers/scsi/scsi_lib.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff -puN drivers/scsi/scsi_lib.c~scsi-remove-superfluous-null-pointer-check-from-scsi_kill_request drivers/scsi/scsi_lib.c > --- a/drivers/scsi/scsi_lib.c~scsi-remove-superfluous-null-pointer-check-from-scsi_kill_request > +++ a/drivers/scsi/scsi_lib.c > @@ -1370,12 +1370,6 @@ static void scsi_kill_request(struct req > > blk_start_request(req); > > - if (unlikely(cmd == NULL)) { > - printk(KERN_CRIT "impossible request in %s.\n", > - __func__); > - BUG(); > - } > - > sdev = cmd->device; > starget = scsi_target(sdev); > shost = sdev->host; > _ -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
