Re: [PATCH 17/20] be2iscsi: Add support for iscsi boot

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/12/2010 12:59 PM, Jayamohan Kallickal wrote:
   This patch contains changes for adding support for iscsi_boot.
Have modified to make read of mac address from chip as a function.

Since this is a rarely used call, I would like to make the call
  to the chip

It actually gets called every logout and every login from the get host param path. If you do not have this info it is not going to work.


+static ssize_t beiscsi_show_boot_tgt_info(void *data, int type, char *buf)
+{
+	struct beiscsi_hba *phba = data;
+	char *str = buf;
+	int rc;
+
+	printk(KERN_ERR " In beiscsi_show_boot_tgt_info type=%d\n", type);


I think you wanted this to be a beiscsi debug statement or at least KERN_INFO or KERN_DEBUG.


+
+static ssize_t beiscsi_show_boot_ini_info(void *data, int type, char *buf)
+{
+	struct beiscsi_hba *phba = data;
+	char *str = buf;
+	int rc;
+
+	printk(KERN_ERR " In beiscsi_show_boot_ini_info type=%d\n", type);

Same as above.

+static ssize_t beiscsi_show_boot_eth_info(void *data, int type, char *buf)
+{
+	struct beiscsi_hba *phba = data;
+	char *str = buf;
+	int rc;
+
+	printk(KERN_ERR " In beiscsi_show_boot_eth_info type = %d\n", type);

Same.

+
+static int beiscsi_setup_boot_info(struct beiscsi_hba *phba)
+{
+	struct iscsi_boot_kobj *boot_kobj;
+	char *set_name;
+
+	set_name = kasprintf(GFP_KERNEL, "iscsi_boot%u", phba->shost->host_no);
+	if (!set_name)
+		return -ENOMEM;
+
+	phba->boot_kset = iscsi_boot_create_kset(set_name);
+	if (!phba->boot_kset) {
+		kfree(set_name);
+		return -ENOMEM;
+	}
+

You should use iscsi_boot_create_host_kset.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux