On Wednesday 07 July 2010, Christoph Hellwig wrote: > On Sat, Jul 03, 2010 at 11:47:17PM +0200, Arnd Bergmann wrote: > > The blktrace driver currently needs the BKL, but > > we should not need to take that in the block layer, > > so just push it down into the driver itself. > > Does blktrace actually need it? Anyway, pushing it down is a good > start. I'm rather sure that the blktrace code does not need the BKL specifically, but it probably needs some form of serialization. Most of the blktrace code holds both the BKL and bdev->bd_mutex, so the right solution is probably to remove the BKL and rely on bd_mutex. It should be straightforward to do for anyone who understands the blktrace code. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html