Looking at this again I don't like the foo_unlock_ioctl naming you're adding. Just rename the existing ioctl routines to foo_locked_ioctl or move the lock_kernel/unlock_kernel calls into the function, which would be even better. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html