>>This one's giving a single rejection: >> >>patching file drivers/scsi/bfa/bfad_drv.h >>Hunk #2 FAILED at 197. >>1 out of 2 hunks FAILED -- saving rejects to file >>drivers/scsi/bfa/bfad_drv.h.rej >> >>But it looks to be serious: then hunk is: >> >>+++ drivers/scsi/bfa/bfad_drv.h >>@@ -197,12 +199,18 @@ >> bfa_boolean_t ipfc_enabled; >> union bfad_tmp_buf tmp_buf; >> struct fc_host_statistics link_stats; >>+ struct list_head pbc_pcfg_list; >> u32 fwtrc_len; >> char *fwtrc; >> u32 reglen; >> char *regdata; >> }; >> >>But the defined structure in the file is: >> >> bfa_boolean_t ipfc_enabled; >> union bfad_tmp_buf tmp_buf; >> struct fc_host_statistics link_stats; >>}; >> >>So there's quite a bit missing somewhere. >> >>James >> > >Hi James, > >This patch set depends on the patch sent out earlier by Krishna Guidapt to collect >debug info >using sysfs binary attributes, here is the link to the patch: > >http://marc.info/?l=linux-scsi&m=127604326602491&w=2 > >It enables the basics debuggability the current upstream driver lacks as a result of >IOCTL >removal, so that when there is some issue happen in the firmware/hardware, when >can >use them to dump out firmware trace and read/write to the chip registers. > >If you need more time to review or have any concern on that particular patch, >please let me know, >I can recreate the 2.2.2.1 patch set without that change so that they can be applied >cleanly to the >current scsi-misc tree. > >Thanks > >Jing > > Hi James, Any comments on my response above? Do you want me to remove the dependency on Krishna's patch and resubmit? Regards, Jing ��.n��������+%������w��{.n�����{������ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
