On Fri, Jun 18, 2010 at 01:16:07PM -0700, Justin P. Mattock wrote: > @@ -420,7 +419,8 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize) > shost->ehandler = kthread_run(scsi_error_handler, shost, > "scsi_eh_%d", shost->host_no); > if (IS_ERR(shost->ehandler)) { > - rval = PTR_ERR(shost->ehandler); > + printk(KERN_WARNING "scsi%d: error handler thread failed to spawn, error = %ld\n", > + shost->host_no, PTR_ERR(shost->ehandler)); Surely this should simply be: shost_printk(KERN_WARNING, shost, "error handler thread failed" "to spawn (%ld)\n", PTR_ERR(shost->ehandler)); > goto fail_kfree; > } > > -- > 1.7.1.rc1.21.gf3bd6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html