NAK. You're really only creation a mini-BKL here without sorting out the locking. Please go through the individual callers and sort them out. Start by pushing the remaining ioctls to the unlocked version and moving the BKL into the ->open and ->release methods. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html