On Tue, Jun 01, 2010 at 10:29:30AM -0600, Matthew Wilcox wrote: > On Tue, Jun 01, 2010 at 09:49:51AM -0400, Chris Mason wrote: > > > I agree that a block based retry would close all the holes ... it just > > > doesn't look elegant to me that the fs will already be repeating the I/O > > > if it changed the page and so will block. > > > > We might not ever repeat the IO. We might change the page, write it, > > change it again, truncate the file and toss the page completely. > > Why does it matter that it was never written in that case? It matters is the storage layer is going to wait around for the block to be written again with a correct crc. Unless there is trim + DIF, but that's a lot of plates to spin just for a basic implementation. -chris -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
