On Tue, 2010-06-01 at 11:19 +0200, Hannes Reinecke wrote: > When using SCSI reservations a 'reservation conflict' error > is actually expected. So we should better use the normal > SCSI_LOG_XXX functions to make it configurable for those > cases where we're actually interested in the error. > > Signed-off-by: Hannes Reinecke <hare@xxxxxxx> > > diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c > index a5d630f..def540d 100644 > --- a/drivers/scsi/scsi_error.c > +++ b/drivers/scsi/scsi_error.c > @@ -1509,8 +1509,8 @@ int scsi_decide_disposition(struct scsi_cmnd *scmd) > return SUCCESS; > > case RESERVATION_CONFLICT: > - sdev_printk(KERN_INFO, scmd->device, > - "reservation conflict\n"); > + SCSI_LOG_ERROR_RECOVERY(3, sdev_printk(KERN_INFO, scmd->device, > + "reservation conflict\n")); > return SUCCESS; /* causes immediate i/o error */ > default: > return FAILED; Makes perfect sense to me. :-) Acked-by: Nicholas A. Bellinger <nab@xxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
