Re: [PATCH 7/11] drivers/scsi: Eliminate a NULL pointer dereference

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Dan Carpenter schrieb:
> On Thu, May 27, 2010 at 02:33:47PM +0200, Julia Lawall wrote:
>> If it is a problem to use 0 when host is NULL, then the code could be fixed
>> in another way.
>>
> 
> Yeah.  It seems like it would be better to give a clearly bogus number.
> I would have said -1 but "scsi-1" looks normal so maybe something like 
> 9999999?
> 

lets spend some bytes:

	
	if (host)
		dprintk("scsi%d: hptiop_probe failed\n",host->host_no);
	else
		dprintk("scsi: no host, hptiop_probe failed\n");



re,
 wh

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux