On Wed, 2010-05-26 at 12:55 +0800, Nick Cheng wrote: > 1. To support 4M/1024 scatter-gather list entry, reorganize struct > ARCMSR_CDB and struct CommandControlBlock > 2. To modify arcmsr_probe > 3. In order to help fix F/W issue, add the driver mode for type B card > 4. To improve AP's behavior while F/W resets > 5. To unify struct MessageUnit_B's members' naming in all OS drivers' > 6. To improve error handlers, arcmsr_bus_reset(), arcmsr_abort() > 7. To fix the arcmsr_queue_command() in bus reset stage, just let the > commands pass down to FW, don't block > Signed-off-by: Nick Cheng< nick.cheng@xxxxxxxxxxxx > > --- Hi Nick. These patches don't use normal kernel coding style. Can you run scripts/checkpatch.pl against them please. You've also got continuation lines like this: + printk(KERN_NOTICE "arcmsr%d: wait 'flush adapter cache' \ + timeout, retry count down = %d \n", acb->host->host_no, which are defective because of the additional white space introduced into the format string after the line continuations. These should written as: printk(KERN_NOTICE "arcmsr%d: wait 'flush adapter cache' " "timeout, retry count down = %d\n", I did submit patches to Erich Chen <support@xxxxxxxxxxxx> to fix the some of the existing problems. http://patchwork.kernel.org/patch/75997/ -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
