The "fcport" variable is never null here. I've updated the condition to test for the end of the list_for_each_entry() loop. Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c index b905dfe..14ca275 100644 --- a/drivers/scsi/qla2xxx/qla_bsg.c +++ b/drivers/scsi/qla2xxx/qla_bsg.c @@ -1050,7 +1050,7 @@ qla24xx_iidma(struct fc_bsg_job *bsg_job) break; } - if (!fcport) { + if (&fcport->list == &vha->vp_fcports) { DEBUG2(printk(KERN_ERR "%s(%ld): Failed to find port\n", __func__, vha->host_no)); return -EINVAL; -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html