On Tue, May 04 2010 at 12:01am -0400,
Mike Anderson <andmike@xxxxxxxxxxxxxxxxxx> wrote:
> Add a feature flag attribute to the multipath structure.
>
> Signed-off-by: Mike Anderson <andmike@xxxxxxxxxxxxxxxxxx>
> ---
> drivers/md/dm-mpath.c | 10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
> index 826bce7..4200d03 100644
> --- a/drivers/md/dm-mpath.c
> +++ b/drivers/md/dm-mpath.c
> @@ -82,6 +82,7 @@ struct multipath {
> unsigned saved_queue_if_no_path;/* Saved state during suspension */
> unsigned pg_init_retries; /* Number of times to retry pg_init */
> unsigned pg_init_count; /* Number of times pg_init called */
> + unsigned long features;
Why not use uint64_t?
> struct work_struct process_queued_ios;
> struct list_head queued_ios;
> @@ -118,6 +119,15 @@ static void trigger_event(struct work_struct *work);
> static void activate_path(struct work_struct *work);
> static void deactivate_path(struct work_struct *work);
>
> +static int multipath_test_feature(struct multipath *m, unsigned feature)
> +{
> + return test_bit(feature, &m->features);
> +}
> +
> +static void multipath_set_feature(struct multipath *m, unsigned feature)
> +{
> + set_bit(feature, &m->features);
> +}
You're using 'unsigned long' for features yet these wrapper functions
take 'unsigned'. unsigned allows you to use {test,set}_bit but in the
end we have fewer flags to work with...
Granted you're introducing the very first flag but... ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
