On 05/04/10 10:36, James Bottomley wrote: > On Tue, 2010-05-04 at 10:28 -0700, Randy Dunlap wrote: >> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx> >> >> cxgb3i should depend on NET since it selects SCSI_ISCSI_ATTRS, >> which depends on NET. >> This change fixes multiple build (link) errors: >> >> ERROR: "skb_trim" [drivers/scsi/scsi_transport_iscsi.ko] undefined! >> ERROR: "netlink_kernel_create" [drivers/scsi/scsi_transport_iscsi.ko] undefined! >> ERROR: "netlink_kernel_release" [drivers/scsi/scsi_transport_iscsi.ko] undefined! >> ERROR: "skb_pull" [drivers/scsi/scsi_transport_iscsi.ko] undefined! >> ERROR: "init_net" [drivers/scsi/scsi_transport_iscsi.ko] undefined! >> ERROR: "__alloc_skb" [drivers/scsi/scsi_transport_iscsi.ko] undefined! >> ERROR: "netlink_broadcast" [drivers/scsi/scsi_transport_iscsi.ko] undefined! >> ERROR: "kfree_skb" [drivers/scsi/scsi_transport_iscsi.ko] undefined! >> ERROR: "skb_put" [drivers/scsi/scsi_transport_iscsi.ko] undefined! >> >> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx> >> Cc: Karen Xie <kxie@xxxxxxxxxxx> >> --- >> drivers/scsi/cxgb3i/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- lnx-2634-rc6.orig/drivers/scsi/cxgb3i/Kconfig >> +++ lnx-2634-rc6/drivers/scsi/cxgb3i/Kconfig >> @@ -1,6 +1,6 @@ >> config SCSI_CXGB3_ISCSI >> tristate "Chelsio S3xx iSCSI support" >> - depends on CHELSIO_T3_DEPENDS >> + depends on CHELSIO_T3_DEPENDS && NET > > Something's seriously wrong here. > > CHELSIO_T3_DEPENDS is supposed to be the rollup for all the > dependencies. It's actually defined as this: > > config CHELSIO_T3_DEPENDS > tristate > depends on PCI && INET > default y > > INET is the tcp/ip stack ... so how did you build a kernel that has > NET=n and INET=y (it's guarded by an #if NET in the Kconfig file)? Hm, I managed to do that somehow, but I didn't save the Kconfig file and I can't make it happen again, so just drop this patch. Thanks. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
