Hi James, It seems you set CONFIG_SCSI_ARCMSR_AER. Could you undefine it? I will remove this section. -----Original Message----- From: James Bottomley [mailto:James.Bottomley@xxxxxxx] Sent: Monday, May 03, 2010 9:00 PM To: nick.cheng@xxxxxxxxxxxx Cc: linux-scsi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx Subject: Re: [PATCH 1/3 ] SCSI: Support HW reset for EH and polling scheme for scsi device(This is correct revision, please ignore last one) On Mon, 2010-05-03 at 15:45 +0800, Nick Cheng wrote: > 1. To support instantaneous report for SCSI device existing by periodic > polling > 2. In arcmsr_iop_xfer(), inform AP of F/W's deadlock state to prevent > endless waiting > 3. To block the coming SCSI command while the driver is handling bus reset > 4. To support HW reset in bus reset error handler > Signed-off-by: Nick Cheng< nick.cheng@xxxxxxxxxxxx > This patch still isn't compiling: CC [M] drivers/scsi/arcmsr/arcmsr_hba.o drivers/scsi/arcmsr/arcmsr_hba.c: In function 'arcmsr_pci_slot_reset': drivers/scsi/arcmsr/arcmsr_hba.c:2733: error: too few arguments to function 'arcmsr_get_firmware_spec' make[1]: *** [drivers/scsi/arcmsr/arcmsr_hba.o] Error 1 make: *** [drivers/scsi/arcmsr/arcmsr.ko] Error 2 It looks like you missed converting one of the arcmsr_get_firmware_spec() to the two argument prototype. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html