On Fri, 2010-04-23 at 10:37 +0200, Geert Uytterhoeven wrote: > On Mon, Apr 5, 2010 at 21:42, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > On Mon, Apr 5, 2010 at 08:25, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > >> Instead of abusing the ScsiHost base field I'd prefer if you stick > > > > I wouldn't call it abuse: it's a (MM)IO base address anyway. > > But I see that field was indeed marked `legacy crap' in an otherwise > > innocent looking > > commit to split the SCSI include files... by you ;-) > > > >> a properly typed pointer into the device specific host data. > > > > You mean shost_priv()? That field already contains a pointer to the > > struct WD33C93_hostdata. > > > > But I'll create a new a2091_hostdata struct that contains both the > > WD33C93_hostdata and the a2091_scsiregs pointer (and do the same > > for gvp11.c and a3000.c). It's a bit similar to what sgiwd93.c does, albeit that > > one also uses the legacy base field. > > As I want to avoid introducing bugs by respinning the complicated > parts (the zorro > driver and platform driver conversion patches), I made this change on > top of the 2 > whole patch series. > > A2091 part: I've applied up to 10/21 which should make it easier, but this patch refuses to apply: patch: **** malformed patch at line 230: struct scsi_cmnd *SCpnt, could you respin the remaining patches so they'll actually apply? Thanks, James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
