> - *tcp_source_port_num = (uint16_t) mbox_sts[6] >> 16; > + *tcp_source_port_num = (uint16_t) (mbox_sts[6] >> 16); I wonder why we need that cast at all? The fact that tcp_source_port_num is a uint16_t* should cause the value to get truncated properly anyway. But I agree that this patch is a minimal fix for a real bug. -- Roland Dreier <rolandd@xxxxxxxxx> || For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html