>> Fix the compilation warning in powerpc. > >When fixing a warning, please quote that warning in the patch description! > ><does a cross-build> > >It seems that you're referring to this: > >drivers/scsi/bfa/bfa_ioc.c: In function 'bfa_ioc_msgget': >drivers/scsi/bfa/bfa_ioc.c:1331: warning: value computed is not used >drivers/scsi/bfa/bfa_ioc_ct.c: In function 'bfa_ioc_ct_notify_hbfail': >drivers/scsi/bfa/bfa_ioc_ct.c:177: warning: value computed is not used >drivers/scsi/bfa/bfa_ioc_ct.c:180: warning: value computed is not used >drivers/scsi/bfa/bfa_ioc_ct.c: In function 'bfa_ioc_ct_pll_init': >drivers/scsi/bfa/bfa_ioc_ct.c:381: warning: value computed is not used >drivers/scsi/bfa/bfa_ioc_ct.c: In function 'bfa_ioc_ct_ownership_reset': >drivers/scsi/bfa/bfa_ioc_ct.c:421: warning: value computed is not used >drivers/scsi/bfa/bfa_ioc_cb.c: In function 'bfa_ioc_cb_notify_hbfail': >drivers/scsi/bfa/bfa_ioc_cb.c:99: warning: value computed is not used >drivers/scsi/bfa/bfa_ioc_cb.c: In function 'bfa_ioc_cb_ownership_reset': >drivers/scsi/bfa/bfa_ioc_cb.c:272: warning: value computed is not used > > >> The same change also fixes endian >> issue we found in powerpc test. > >When fixing a bug, please fully describe the bug! > >If this driver has "endian issues" on powerpc then it's quite possible >that this is a running-around-with-hair-on-fire, >must-backport-to-2.6.33.x bugfix. > >But how would I know? You didn't tell me! > Hi Andrew, Sorry about the obscure description of the patch, I will provide detailed description in the future patch submission. Yes this patch is intended to fix the compilation warning you listed above. Regarding the big endian issue I mentioned, basically I remove an unnecessary word swap in bfa_os_reg_read() and bfa_os_reg_write() because the kernel provided readl and writel are already doing so. The compilation warning also goes away after this change. For bfa_os_mem_read() and bfa_os_mem_write() macros, I add a swap since these two macros are designed to read/write from/to a memory region that is in BE format per ASIC spec. Thanks Jing -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
