On Wed, Apr 14, 2010 at 03:15:14PM +0900, Tomohiro Kusumi wrote: >Hi > >This patch fixes sdev_rw_attr() macro for scsi device sysfs entries. >It seems there is no such function snscanf in the current linux kernel, Yes! Good catch! >so it fails to compile scsi driver when someone try to add a new rw entry. >This has been unfixed for a long time probably because current scsi device >has no rw entries. > Really? I compiled it in my configuration, but i don't see any compile error. Hmm, i think we are lucky, no one is using the macro sdev_rw_attr() currently. ># grep snscanf . -rn >./drivers/scsi/scsi_sysfs.c:489: snscanf (buf, 20, format_string, &sdev->field); \ > >Thanks, >Tomohiro Kusumi > > > >Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@xxxxxxxxxxxxxx> Acked-by: WANG Cong <xiyou.wangcong@xxxxxxxxx> Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
