On Monday 12 April 2010 14:06:18 you wrote: > From: Mike Christie <michaelc@xxxxxxxxxxx> > > This patch just converts the iscsi_ibft module to the > iscsi boot sysfs lib module. > > This patch was made over the ibft-2.6 tree's ibft-1.03 branch: > http://git.kernel.org/?p=linux/kernel/git/konrad/ibft-2.6.git;a=shortlog;h= >refs/heads/ibft-1.03 > > Signed-off-by: Mike Christie <michaelc@xxxxxxxxxxx> > I've only two comments: .. snip.. > /* > + * Helper routiners to check to determine if the entry is valid > + * in the proper iBFT structure. > + */ > +static mode_t ibft_check_nic_for(void *data, int type) > +{ > + struct ibft_kobject *entry = data; > + struct ibft_nic *nic = entry->nic; > + mode_t rc = 0; > + > + switch (type) { > + case ISCSI_BOOT_ETH_INDEX: > + case ISCSI_BOOT_ETH_FLAGS: > + rc = 1; Did you mean for that value? > + break; > + case ISCSI_BOOT_ETH_IP_ADDR: > + if (memcmp(nic->ip_addr, nulls, sizeof(nic->ip_addr))) > + rc = S_IRUGO; > + break; > + case ISCSI_BOOT_ETH_SUBNET_MASK: > + if (nic->subnet_mask_prefix) > + rc = S_IRUGO; > + break; > + case ISCSI_BOOT_ETH_ORIGIN: > + rc = 1; and this one as well? -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
