Re: Proposal for BSG Interface -V2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/30/2010 06:48 PM, Jayamohan Kallickal wrote:
	Have modified the code as per code review provided to
remove Generic VENDOR opcode in the driver


You forgot to remove that code from the class code, and you forgot to use kmap like we talked about.

I just sent a patch to try and make the fc bsg code a lib, so try that out. For the iscsi code I think it just needs a fix up to sg_virt code (should be using kmap) and it needs a kfree on the completion path (looks like your patch was leaking what is in the va pointer and I did not fix that yet).
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux