Re: PATCH] BNX2I : Bug fixes related to MTU change issue when there are active iscsi sessions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2010-04-08 at 15:31 -0700, Mike Christie wrote:
> On 04/08/2010 04:16 PM, Anil Veerabhadrappa wrote:
> > +	/* Wait for all endpoints to be torn down, Chip will be reset once
> > +	 *  control returns to network driver. So it is required to cleanup and
> > +	 * release all connection resources before returning from this routine.
> > +	 */
> > +	wait_event_interruptible_timeout(hba->eh_wait,
> > +					 (hba->ofld_conns_active == 0),
> > +					 hba->hba_shutdown_tmo);
> 
> 
> Hey, I just noticed this (sorry I should have seen this earlier), but 
> there is no wake_up(hba->eh_wait). Do you want one in bnx2i_free_ep when 
> ofld_conns_active goes to 0?

Thanks Mike. Missed this bit while merging. It is better to call
wake_up() at the end of bnx2i_ep_disconnect() after bnx2i driver
unregisters the device. I will resend the patch.

Thanks again.


> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux