On Wed, 2010-03-03 at 17:41 -0800, kgudipat@xxxxxxxxxxx wrote: > From: Krishna Gudipati <kgudipat@xxxxxxxxxxx> > > Hi James, > > We are resubmitting brocade bfa 2.1.2.1 driver patch. > > I have made the patches bisectable, now each patch depends only on things > > in its predecessor and is compilable. > > > About this submission, we completely reworked the patch set by hand merging > > previous checkins so that each patch addresses a specific issue. > > We hope this patch set meets the upstream standard and gets included in > > your scsi-misc tree. In the following weeks, we will submit more patches > > to clean up the driver and reduce the number of files to be on par > > with most of the upstream drivers. So it's a lot better, thanks! Unfortunately, it's still a modular compile failure bisection problem: MODPOST 904 modules ERROR: "bfa_ioc_set_ct_hwif" [drivers/scsi/bfa/bfa.ko] undefined! ERROR: "bfa_ioc_set_cb_hwif" [drivers/scsi/bfa/bfa.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error 2 The reason for this is patch 10, which splits bfa_ioc_cb.c and .._ct.c from bfa_ioc.c but doesn't actually add the new files into the Makefile. I'll apply patches 2-9 ... can you make sure 10-32 compile individually. I dropped patch 1, because I'm guessing you don't actually want the version number bumping on an incomplete patch set, so you'll need to change the version at the end of the new series. Thanks, James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html