On 02/25/2010 09:28 AM, Martin K. Petersen wrote: >>>>>> "scameron" == scameron <scameron@xxxxxxxxxxxxxxxxxx> writes: > > scameron> BLK_DEF_MAX_SECTORS seems to act as a cap, as a MAXIMUM > scameron> possible value for q->limits->max_sectors in blk_queue_max_sectors, > scameron> but as a MINIMUM for q->limits.max_hw_sectors in > scameron> blk_queue_max_hw_sectors. > > Please read the entire thread. > > blk_queue_max_hw_sectors() is dead, it was never used except briefly by > DM. Device drivers should use blk_queue_max_sectors() to set their hard > limit. > > max_sectors is a block layer soft limit that can be overridden on a > per-device basis in /sys/block/foo/queue/max_sectors_kb. > It seems like the confusion calls for a rename. We are made to believe that the accessors naming convention is the same as the queue member it changes. But here it is named as another very confusing member. At least if the name is not changed, a big fat comment is do, that says this is for drivers to change the *max_hw_sectors* though it is named after that other - not for drivers - member. Just my $0.017 Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
