Frans Pop wrote: > James Bottomley wrote: >>> - printk(KERN_NOTICE "arcmsr%d: wait 'flush adapter cache' \ >>> - timeout, retry count down = %d \n", acb->host->host_no, retry_count); >> >> So I might personally dislike this style > > The problem here is not style, but that the whitespace of the indentation > on the second line becomes part of the output! > That makes the code defective and is why Joe posted the patch series. Joe could have pointed this out in the changelog. s/are not good/incorporate unintended whitespace/ [James wrote:] >> Why? It's perfectly valid ansi C. Its syntax is valid but not its semantics. >> Consider this change veto'd unless you can get an explicit ack from the >> current maintainer for changing their style. How about the maintainer takes the fix patch and adjusts style to his liking? (That's what I would do because I like fix submissions.) -- Stefan Richter -=====-==-=- --=- ---=- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
