On 01/30/2010 12:29 AM, Ravi Anand wrote:
From: Vikas Chaudhary<vikas.chaudhary@xxxxxxxxxx>
Signed-off-by: Nilesh Javali<nilesh.javali@xxxxxxxxxx>
Signed-off-by: Vikas Chaudhary<vikas.chaudhary@xxxxxxxxxx>
Signed-off-by: Ravi Anand<ravi.anand@xxxxxxxxxx>
---
drivers/scsi/qla4xxx/ql4_os.c | 27 ++++++++++++++++++++++++---
1 files changed, 24 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
index 9057860..e5c9b85 100644
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -370,6 +370,7 @@ void qla4xxx_mark_device_missing(struct scsi_qla_host *ha,
ddb_entry->fw_ddb_index));
iscsi_block_session(ddb_entry->sess);
iscsi_conn_error_event(ddb_entry->conn, ISCSI_ERR_CONN_FAILED);
+ set_bit(DF_NO_RELOGIN,&ddb_entry->flags);
}
/***
@@ -642,6 +643,24 @@ static void qla4xxx_timer(struct scsi_qla_host *ha)
/* Search for relogin's to time-out and port down retry. */
list_for_each_entry_safe(ddb_entry, dtemp,&ha->ddb_list, list) {
+ /* First check to see if the device has exhausted the
+ * port down retry count */
+ if (atomic_read(&ddb_entry->state) == DDB_STATE_MISSING) {
+ if (atomic_read(&ddb_entry->port_down_timer) == 0)
+ continue;
+
How does the relogin work in this case?
- If you pull a cable and we mark devices missing, then when link up is
detected will qla4xxx_isr_decode_mailbox set the AF_LINK_UP bit and then
the driver will start to try and relogin? Or would you get a
MBOX_ASTS_DATABASE_CHANGED aen, and then that notifies you that that the
firmware detected link up and logged back in (so the state would then be
DDB_DS_SESSION_ACTIVE?)?
- What cases do you get a databased change aen where the new device
state indicates the session is non active so qla4xxx_process_ddb_changed
calls qla4xxx_mark_device_missing? Would it be where the target logs us
out, or when the firmware detects a problem with the session/connection
and drop the session, what about if the firmware detects a link down?
In the case qla4xxx_process_ddb_changed calls
qla4xxx_mark_device_missing will we get some sort of databased change
aen indicating that the state is again DDB_DS_SESSION_ACTIVE?
- What cases do we now use the relogin code now? Do we always call
qla4xxx_mark_device_missing in cases where a relogin is needed, so can
we just remove the relogin code? Or is the relogin code still used for
the initial driver initialization or something else?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
