On Jan 18, 2010, at 2:47 PM, James Bottomley wrote:
On Tue, 2010-01-12 at 13:02 -0800, giridhar.malavali@xxxxxxxxxx wrote:
From: Giridhar Malavali <giridhar.malavali@xxxxxxxxxx>
Signed-off-by: Sarang Radke <sarang.radke@xxxxxxxxxx>
Signed-off-by: Giridhar Malavali <giridhar.malavali@xxxxxxxxxx>
---
drivers/scsi/qla2xxx/qla_attr.c | 746
++++++++++++++++++++++++++++++++++++++-
drivers/scsi/qla2xxx/qla_def.h | 155 ++++++++
drivers/scsi/qla2xxx/qla_fw.h | 33 ++
drivers/scsi/qla2xxx/qla_gbl.h | 5 +
drivers/scsi/qla2xxx/qla_init.c | 14 +-
drivers/scsi/qla2xxx/qla_iocb.c | 120 +++++++
drivers/scsi/qla2xxx/qla_isr.c | 105 ++++++-
drivers/scsi/qla2xxx/qla_mbx.c | 151 ++++++++
drivers/scsi/qla2xxx/qla_os.c | 1 +
9 files changed, 1326 insertions(+), 4 deletions(-)
Did this actually get compile checked? It's giving me this error:
Thanks for the fix. Yes, it compiled without any warnings or errors on
my X86 64 bit system. It missed compilation on 32 bit system.
I will make sure I cross compile in future before submitting.
drivers/scsi/qla2xxx/qla_attr.c: In function
'qla2x00_process_vendor_specific':
drivers/scsi/qla2xxx/qla_attr.c:2233: warning: format '%llx' expects
type 'long long unsigned int', but argument 5 has type 'dma_addr_t'
drivers/scsi/qla2xxx/qla_attr.c:2233: warning: format '%llx' expects
type 'long long unsigned int', but argument 6 has type 'dma_addr_t'
drivers/scsi/qla2xxx/qla_attr.c:2251: warning: format '%llx' expects
type 'long long unsigned int', but argument 5 has type 'dma_addr_t'
drivers/scsi/qla2xxx/qla_attr.c:2251: warning: format '%llx' expects
type 'long long unsigned int', but argument 6 has type 'dma_addr_t'
A simple cast fixes it.
James
---
diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/
qla_attr.c
index 6ecbda9..5a19aea 100644
--- a/drivers/scsi/qla2xxx/qla_attr.c
+++ b/drivers/scsi/qla2xxx/qla_attr.c
@@ -2232,7 +2232,7 @@ qla2x00_process_vendor_specific(struct
fc_bsg_job *bsg_job)
vha->host_no, type, vendor_cmd, elreq.options));
DEBUG2(qla_printk(KERN_INFO, ha,
"scsi(%ld) tx_addr: 0x%llx rx_addr: 0x%llx tx_sg_cnt: %x
rx_sg_cnt: %x\n",
- vha->host_no, elreq.send_dma, elreq.rcv_dma, elreq.req_sg_cnt,
elreq.rsp_sg_cnt));
+ vha->host_no, (unsigned long long)elreq.send_dma, (unsigned
long long)elreq.rcv_dma, elreq.req_sg_cnt, elreq.rsp_sg_cnt));
command_sent = INT_DEF_LB_LOOPBACK_CMD;
rval = qla2x00_loopback_test(vha, &elreq, response);
if (IS_QLA81XX(ha)) {
@@ -2250,7 +2250,7 @@ qla2x00_process_vendor_specific(struct
fc_bsg_job *bsg_job)
vha->host_no, type, vendor_cmd, elreq.options));
DEBUG2(qla_printk(KERN_INFO, ha,
"scsi(%ld) tx_addr: 0x%llx rx_addr: 0x%llx tx_sg_cnt: %x
rx_sg_cnt: %x\n",
- vha->host_no, elreq.send_dma, elreq.rcv_dma, elreq.req_sg_cnt,
elreq.rsp_sg_cnt));
+ vha->host_no, (unsigned long long)elreq.send_dma, (unsigned
long long)elreq.rcv_dma, elreq.req_sg_cnt, elreq.rsp_sg_cnt));
command_sent = INT_DEF_LB_ECHO_CMD;
rval = qla2x00_echo_test(vha, &elreq, response);
}
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
