Re: [Pv-drivers] [PATCH] PVSCSI: fix signedness warning with newer compilers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 19 January 2010 10:23:43 am James Bottomley wrote:
> On Tue, 2010-01-19 at 10:20 -0800, Dmitry Torokhov wrote:
> > On Tuesday 19 January 2010 10:19:04 am Alok Kataria wrote:
> > > On Tue, 2010-01-19 at 10:08 -0800, James Bottomley wrote:
> > > > On Tue, 2010-01-19 at 10:04 -0800, Alok Kataria wrote:
> > > > > On Tue, 2010-01-19 at 09:38 -0800, Dmitry Torokhov wrote:
> > > > > > pvscsi_setup_msix() expects 'irq' argument to be an int but is
> > > > > > being passed unsigned int. Unsigned int is more proper type for
> > > > > > IRQ number so let's use it. This shuts off a compile warning with
> > > > > > recent compilers.
> > > > > >
> > > > > > Signed-off-by: Dmitry Torokhov <dtor@xxxxxxxxxx>
> > > > >
> > > > > LGTM.
> > > > >
> > > > > Signed-off-by: Alok N Kataria <akataria@xxxxxxxxxx>
> > > >
> > > > That would be acked-by unless you want to resend the patch to me?  I
> > > > don't have an unmangled copy of it, so someone needs to send it to
> > > > the scsi list.
> > >
> > > Acked-by is fine with me too. If its an hassle to pick these lines
> > > after the patch is sent, I am totally fine if you pick the patch
> > > without my Acked-by or SOB line, just wanted to acknowledge that the
> > > change is fine by me.
> >
> > Hm, I wonder why the original did not make through to linux-scsi/James.
> > I will resend from my other address then.
> 
> Well, sometimes it's because someone is using a mail tool that breaks
> threading ... but I did a subject search, it definitely isn't in my
> folder.  Vger has a fairly esoteric spam reduction mechanism based on
> regexps ... perhaps you fell foul of that?

Mutt usually does not fail me when sending patches. Let's see if my other 
account works better.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux