Re: [Pv-drivers] [PATCH] PVSCSI: fix signedness warning with newer compilers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2010-01-19 at 09:38 -0800, Dmitry Torokhov wrote:
> pvscsi_setup_msix() expects 'irq' argument to be an int but is being
> passed unsigned int. Unsigned int is more proper type for IRQ number
> so let's use it. This shuts off a compile warning with recent
> compilers.
> 
> Signed-off-by: Dmitry Torokhov <dtor@xxxxxxxxxx>

LGTM.

Signed-off-by: Alok N Kataria <akataria@xxxxxxxxxx>

Thanks.
> ---
>  drivers/scsi/vmw_pvscsi.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c
> index d2604c8..e4ac582 100644
> --- a/drivers/scsi/vmw_pvscsi.c
> +++ b/drivers/scsi/vmw_pvscsi.c
> @@ -1069,7 +1069,8 @@ static void pvscsi_free_sgls(const struct pvscsi_adapter *adapter)
>  		free_pages((unsigned long)ctx->sgl, get_order(SGL_SIZE));
>  }
>  
> -static int pvscsi_setup_msix(const struct pvscsi_adapter *adapter, int *irq)
> +static int pvscsi_setup_msix(const struct pvscsi_adapter *adapter,
> +			     unsigned int *irq)
>  {
>  	struct msix_entry entry = { 0, PVSCSI_VECTOR_COMPLETION };
>  	int ret;
> 
> _______________________________________________
> Pv-drivers mailing list
> Pv-drivers@xxxxxxxxxx
> http://mailman2.vmware.com/mailman/listinfo/pv-drivers

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux