James Smart <james.smart@xxxxxxxxxx> writes: > The short response: > Acked-by: James Smart <james.smart@xxxxxxxxxx> > > > Background: > Nothing Broke. This was intended. > > We had originally enabled MSI-X by default, but in qualification > within the last 12 months, we encountered a major catch-22: > > There were at least 4 platforms, from 2 major OEMs, that : > - Say they support MSI-X - platform routines work and act as if they do. > - We enable it, generate a test interrupt to check they really do > deliver it, and it works. > - But shortly after attachment, the system hangs or loses interrupts, > resulting in a bad system behavior. > > Given the distro's picking up the 2.6.32 kernel, we had to stick with > a default of MSI-X off, with user-enabled MSI-X as these platforms > couldn't get fixed. > > However, we're also now encountering platforms that require MSI-X and > never INTx, so we must change. It's desired also for also for > performance reasons. > > So - now (2.6.33) is the right time to re-enable MSI-X by default. > > > -- james s > So I see! Thanks for the clarification. It was just that your commit's description didn't mention the interrupt method change at all (and I also couldn't find any information on the internet), and I thought it was accidental. Anyway, all in all, I think that the correct course of action here is to have MSI-X as the default (for the reasons you described) and users with defective systems can enable INTx manually. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
