On Tue, 5 Jan 2010, Boaz Harrosh wrote: > On 01/05/2010 05:20 PM, Alan Stern wrote: > > On Tue, 5 Jan 2010, Boaz Harrosh wrote: > > > >> Embedding scsi_end_request() into scsi_io_completion actually simplifies > >> the code and makes it clearer what's going on. > >> > >> There is absolutely no functional and/or side effects changes after this > >> patch. > > > > Here are some suggestions for changes to the comments. These are quite > > minor and you might not want to bother updating the patch yet again... > > > > Sure, NP. thanks for checking me out, coming from Hebrew I do need support > in these matters. Will update tomorrow. > > Alan can I add your Review-by: this time around? Yes. This is a good step. It will make adding functional changes a lot easier, and it will help if anyone wants to split up scsi_io_completion() into several smaller routines. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
