On 01/04/2010 03:23 PM, Matthew Wilcox wrote: > On Mon, Jan 04, 2010 at 02:17:06PM +0200, Boaz Harrosh wrote: >> Embedding scsi_end_request() into scsi_io_completion actually simplifies the >> code and makes it clearer what's going on. > > I'm not entirely convinced about that -- scsi_io_completion is currently > over 200 lines long and needs to be made shorter, not longer. That said, > I see no reason that the current factoring of scsi_io_completion() makes > sense; pushing the decoding of the sense key into a separate function > looks like a more profitable idea. It would also let you do without > the nasty gotos you add in this patch. > I agree, but I want that Alan's retries handling, Hannes's sense for FS_COMMANDS and mainly the question about good_bytes!=0 and retries are answered first. Then we can see what the code is really like and make a clean cut. I'll attempt a second version without the goto. >> There is absolutely no functional and/or side effects changes after this patch. >> >> Patch was inspired by Alan Stern. >> >> CC: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> >> Signed-off-by: Boaz Harrosh <bharrosh@xxxxxxxxxxx> <snip> Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
