On Mon, Dec 28, 2009 at 12:14:39PM -0500, Joe Eykholt wrote:
>
>
> Dan Carpenter wrote:
>> The check should be >= instead of > or we could go past the end of the
>> array.
>
> What about the LUN check? I'm not sure either way, but usually MAX LUN
> is the max number of LUNs, not the max LU number, although that's been
> in flux lately.
>
No no. You're clearly correct. That matches how MAX_LUN is used throughout
the file.
Will send an updated patch.
regards,
dan carpenter
>>
>> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
>>
>> --- orig/drivers/scsi/FlashPoint.c 2009-12-27 11:35:58.000000000 +0200
>> +++ devel/drivers/scsi/FlashPoint.c 2009-12-27 11:36:19.000000000 +0200
>> @@ -3924,7 +3924,7 @@
>> {
>> struct sccb_mgr_tar_info *currTar_Info;
>> - if ((p_sccb->TargID > MAX_SCSI_TAR) || (p_sccb->Lun > MAX_LUN)) {
>> + if ((p_sccb->TargID >= MAX_SCSI_TAR) || (p_sccb->Lun > MAX_LUN)) {
>> return;
>> }
>> currTar_Info = &FPT_sccbMgrTbl[p_card][p_sccb->TargID];
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
