Re: [patch 01/19] scsi: add __init/__exit macros to ibmvstgt.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Dienstag 22 Dezember 2009 01:27:38 schrieb akpm@xxxxxxxxxxxxxxxxxxxx:
> From: Peter Huewe <peterhuewe@xxxxxx>
> 
> Add the __init and __exit macros to the module_init / module_exit
> functions from drivers/scsi/ibmvscsi/ibmvstgt.c
> 
> Signed-off-by: Peter Huewe <peterhuewe@xxxxxx>
> Acked-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>
> Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Cc: James Bottomley <James.Bottomley@xxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
> 
>  drivers/scsi/ibmvscsi/ibmvstgt.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff -puN
>  drivers/scsi/ibmvscsi/ibmvstgt.c~scsi-add-__init-__exit-macros-to-ibmvstgt
> c drivers/scsi/ibmvscsi/ibmvstgt.c ---
>  a/drivers/scsi/ibmvscsi/ibmvstgt.c~scsi-add-__init-__exit-macros-to-ibmvst
> gtc +++ a/drivers/scsi/ibmvscsi/ibmvstgt.c
> @@ -955,7 +955,7 @@ static struct srp_function_template ibmv
>  	.it_nexus_response = ibmvstgt_it_nexus_response,
>  };
> 
> -static int ibmvstgt_init(void)
> +static int __init ibmvstgt_init(void)
>  {
>  	int err = -ENOMEM;
> 
> @@ -986,7 +986,7 @@ release_transport:
>  	return err;
>  }
> 
> -static void ibmvstgt_exit(void)
> +static void __exit ibmvstgt_exit(void)
>  {
>  	printk("Unregister IBM virtual SCSI driver\n");
> 
> _
> 

Hi,

this patch is floating around for almost half a year (2009/06/23) and I was 
wondering if there is anything wrong with it, or why it doesn't get merged 
upstream.

I know the patch is really trivial and maybe not even worth this email, but in 
my opinion every single line counts :)

@James: Do you prefer if Jiri Kosina merges this one through his trivial tree?


Thanks,
Peter


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux