Re: [PATCH 02/38] move atp870u_remove to .devexit.text

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 24, 2009 at 03:38:16PM -0600, James Bottomley wrote:
> On Tue, 2009-11-24 at 22:06 +0100, Uwe Kleine-König wrote:
> > The function atp870u_remove is used only wrapped by __devexit_p so define
> > it using __devexit.
> 
> But there's really no point to this.  HOTPLUG is always defined on SCSI
> systems that have these drivers, which means that _devinit/exit are
> nops.  That makes the change purely cosmetic and not worth churning two
> dozen drivers for.
> 
> Even for the EMBEDDED cases that should care about this, the maintainers
> have indicated that the memory savings simply aren't worth the hassle of
> tracking the sectional updates.
I think there are people that care.  Anyhow, then the best thing you can
do is something like

	find drivers/scsi -type f -print0 | xargs perl -p -i -e 's/\b__(dev)?exit(_p)?\b//'

Then my scripts will drop the scsi related patches.

Best regards
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux