Christoph Hellwig wrote:
On Tue, Nov 17, 2009 at 02:52:39PM +0000, Alan Cox wrote:
I'm not convinced that is the right way to handle it. If we start doing
that we'll have this massive unmanagable set of magic flags and twiddles
for every possible host specific corner case.
Far better to keep the issue of the command as Christoph has done and
block the command issue in the afflicted devices qc_issue so that you get
an error back. That keeps the mess in the right places.
Ok, new version of the patch without this will go out this minute. I'm
happy to add whatever patch is nessecary to block it for controllers
that can't accept it once we agree on a method.
..
I imagine some sort of port or host flag, that the LLD could set
to indicate that it can correctly handle TRIM. Or not handle TRIM.
Tejun is pretty good at these flag things.. I wonder what he might suggest?
Cheers
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
