Re: [PATCH] libata: add TRIM support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

Alan Cox wrote:

+	min_io_sectors = 1;
+	if ((args->id[106] & 0xc000) == 0x4000 && (args->id[106] & (1 << 13)))
+		min_io_sectors *= args->id[106] & 0xf;

That magic probably wants to be an ata_id_foo helper of some sort but
otherwise all looks sensible enough for ATA. I'm assuming gcc is smart
enough to collapse that into

	id[106] & 0xE000 != 0x6000

  You probably meant ==, not !=. Not sure if gcc is that smart...

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux