On Thu, 2009-11-12 at 13:58 +0530, Penchala Narasimha Reddy Chilakala, ERS-HCLTech wrote: > Hi James, > > Thank you very much for your suggestion. > > I feel that we need to work out for a better solution which would not > create any issues. We have to go ahead with the patch as it is tested > and working as expected (with out any issues) even though we are > thinking there might be some racy issue until we come out with a > better solution than the current one Sure, I can wait for a better solution. > I am not quite ok with the fix because of the following reasons: > > 1. I feel that calling the dev->management_fib_count-- > statement in one place, that is in dpcsup.c (Whenever interrupt comes > from arcraid controller, the corresponding ISR route will be called > and the value will be decremented, if the response is for the > requested management fib) is good instead of calling the statement in > two places, which are dpcsup.c and commctrl.c. Um, so that's the same mechanism you implemented for this undone fib problem: setting the ->done flag as mediator. > 2. Moving the dev->management_fib_count++ from aac_fib_send () > function to aac_do_ioctl () function did not work well during our > testing (This was suggested by you in one of the earlier mails). That doesn't give me a lot to go on. However, I'm not particularly bothered whose solution it is, just that we have a solution that isn't demonstrably racy. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
